Improvement: Improve ByteBuffers performance #3718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues onging effort on improving nio Buffers performance. Should allow for up to 50% faster execution (no exact benchmark data from before changes), based on debugging of 1 Billions Rows Challange in Scala Native
rawAddress
which is equal to address calculated fromarray.at(arrayOffset)
/mappedData.data + offset
. The only exception isStringCharBuffer
which does not expose pointer to underlying arrays. It's methods are overriden.get
/put
methods inTBuffer
instead of usingGenBuffers
.ByteArrayBits
to implementgetX
/putX
operations on ByteBuffers. Use pointer directly. Each usage of ByteArrayBits coused creation of new instance of this class. ByteArraBits are still used in BufferViews