Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3732: remove some defects in javalib FileChannel transfer methods #3734

Merged

Conversation

LeeTibbert
Copy link
Contributor

Fix #3732

javalib java.nio.channels.FileChannel transferFrom and transferTo methods now more closely match
their JDK descriptions. The first now actually transfers data to the destination. The second no longer
moves the position of the source channel.

Both now check their arguments.

The defects described in Issue #3733 remain.

@LeeTibbert LeeTibbert added component:javalib backport candidate PR which might be backported into previous major release of SN labels Feb 7, 2024
@LeeTibbert
Copy link
Contributor Author

Lets see what the re-try bunny brings overnight. Right now the "Unix JDK compliance" test
is failing for no reason recorded in the log file. The "Linux multiarch test runtime" looks like
it is going to time out (2+ hours and counting).

Other than than, all is Green, like spring time.

@WojciechMazur WojciechMazur merged commit 575b60b into scala-native:main Feb 8, 2024
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport candidate PR which might be backported into previous major release of SN component:javalib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Three bugs in javalib FileChannelImpl transferFrom & transferTo methods
2 participants