Fix #3733: javalib FileChannel transfer* methods now honor Long counts #3746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3733
Two javalib
java.nio.channels.FileChannel
methods,transferFrom
andtransferTo
now more closelyfollow the JVM specification by honoring counts which exceed Integer.MAX_VALUE.
They also more closely follow the specification in a number of ways, argument checking, zero transfers, etc.
Internally, the methods now buffer if the transfer count is greater than an internal limit.
That limit is currently 8192 or 8KB and is subject to change without notice or deprecation.
Two Linux only unit-test cases are provided which transfer more than Integer.MAX_VALUE bytes. These
cases are surprisingly fast and are enabled for CI. If CI execution time or cost becomes a
concern, they can be
@Ignore
d and run manually.A surprising macOS feature/quirk with reading more than a zero byte count from "/dev/zero' keeps these tests
from running there.