refactor: Remove stubs for java.security and java.rmi
#3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove stubs for types defined in packages
java.securityandjava.rmi.java.securitystubs, especially mockMessageDigestgives a false assumptions about security.The only dependency on
java.securityin our code was used inJar{Entry,File, InputStream}for jars verification - this was never tested (the only possible tested for #956 were ignored, so not started) and we have no guarantee it worked at any point. The verification mechanism was disabled (commented out) and might be resoted in the future.All of the removed stubs would become available in https://github.com/scala-native/scala-native-java-stubs (published after 0.5.0 release).
I've also started to work on porting Apache Harmony
java.securityin a side project some time ago. If we'll manage to pass of tests we might restore and finalize JarVerification based on using external dependency or merging side project into core repo as additional, optional module.