Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Execute WeakReference post-cleanup callbacks only in java.lang.Thread #3815

Merged

Conversation

WojciechMazur
Copy link
Contributor

Executing callbacks in GC created thread might have lead to undefined behaviour due to lack of Thread.currentThread() which might have been called by handler.

@WojciechMazur
Copy link
Contributor Author

There shall be green CI light yet again.
This PR should fix some of the remaining spurious CI issues, especially SIGILL found on MacOS in release mode

@WojciechMazur WojciechMazur merged commit 12f886c into scala-native:main Mar 7, 2024
61 checks passed
@WojciechMazur WojciechMazur deleted the fix/weak-refs-handlers branch March 7, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant