improvement: Limit amount of compiled code, restrict glue layer only referenced files. #3849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One idea I had was perhaps we could have different plugin versions or allow the plugin to remove the |
I think it might quite a complex feature to make it correct. Also some of posixlib definitions might be used on Windows, because some of them might be compatible, eg. sockets. In general control of what to be compiled shall be more stable then removing possibly unused ones. |
… actually referenced by the runtime. Ensure to not use stdatomic in singlethreaded mode
…ier support in clangd or as a workaround in case of issues
WojciechMazur
force-pushed
the
improve/compile-only-used-sources
branch
from
9d928f4
to
4bc522b
Compare
|
OMG how did I miss this before? This is amazing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
@defineannotation we can limit amount of glue layer that needs to be compiled - we add an entry for potentially optional bindings and guard the glue-layer with#if defined(x)preprocesor conditions. This should allow to lower number of compilation errors in non-posix compliant systems, especially on 32-bit architectures.The need of controlling the amount of C glue layer files on non-compatible runtimes was already needed in the WASM/WASI prototype https://github.com/WojciechMazur/scala-native/tree/scala-wasm and when targeting Playdate devices (arm v7, limited C/POSIX stdlib) kubukoz#1
Based on these changes we're removing usages of
stdatomicin minimal single-threaded execution