GC Compiler changes #682
Merged
GC Compiler changes #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densh
requested changes
Apr 28, 2017
|
|
||
| /** | ||
| * Created by lukaskellenberger on 08.03.17. | ||
| */ |
There was a problem hiding this comment.
We strongly discourage authorship comments in the code as they quickly get out of date.
| } | ||
|
|
||
| val moduleArrayName = Global.Top("__modules") | ||
| val moduleArraySizeName = Global.Top("__modules_size") |
There was a problem hiding this comment.
Those two above should go the GCExternals companion.
| /** | ||
| * Created by lukaskellenberger on 08.03.17. | ||
| */ | ||
| class GCexternals(top: Top) extends Inject { |
| val modules = defns.filter { | ||
| case _: Defn.Module => true | ||
| case _ => false | ||
| } |
There was a problem hiding this comment.
defns.filter(_.isIntanceOf[Defn.Module])
| def genObjectArrayId(): Defn.Var = { | ||
| val objectArray = | ||
| top.nodes(Global.Top("scala.scalanative.runtime.ObjectArray")) | ||
| val objectArrayIdName = Global.Top("__object_array_id") |
There was a problem hiding this comment.
The line above should go the companion of GCExternals.
LukasKellenberger
force-pushed
the
gc-compiler-changes
branch
from
cd5ef4c
to
a75e3c3
Compare
densh
approved these changes
Apr 29, 2017
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__modules__modules_sizeObjectArrayclass__object_array_id-1.