Clarify recommended LLVM minimum version and library dependencies #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though feature detection is used the sbt plugin will not try to discover LLVM versions older than 3.7. Also update to mention that Scala Native now also depends on RE2.
tindzk
reviewed
May 7, 2017
| so older versions may also work. | ||
|
|
||
| In addition, the native Scala runtime and Java API implementation | ||
| require the Boehm garbage collector and the RE2 regular expression |
There was a problem hiding this comment.
Looks great! We might as well specify the version numbers for completeness.
densh
approved these changes
May 9, 2017
muxanick
pushed a commit
to muxanick/scala-native
that referenced
this pull request
May 25, 2017
…ala-native#706) Even though feature detection is used the sbt plugin will not try to discover LLVM versions older than 3.7. Also update to mention that Scala Native now also depends on RE2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though feature detection is used the sbt plugin will not try to
discover LLVM versions older than 3.7. Also update to mention that Scala
Native now also depends on RE2.