Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preliminary support for segfault-based safepoints #711

Merged
merged 3 commits into from May 9, 2017
Merged

Preliminary support for segfault-based safepoints #711

merged 3 commits into from May 9, 2017

Conversation

densh
Copy link
Member

@densh densh commented May 8, 2017

Safepoints provide a cheap way to suspend application code and transfer control to the runtime. They are necessary for an upcoming concurrent garbage collector.

@DarkDimius
Copy link

DarkDimius commented May 8, 2017 •
edited

While segfault-based safepoints is a good foundation to build performant garbage collection on,
it would make it substantially harder to embed scala-native applications inside virtually anything, in particular, to invoke scala-native through JNI.

Do you plan to support both modes or is embedding a use-case that is not a priority?

@densh
Copy link
Member Author

densh commented May 8, 2017 •
edited

@DarkDimius Embedding is not officially supported at the moment, so it's not a concern for now. We can revisit this issue in the future.

ekrich
ekrich reviewed May 8, 2017
View reviewed changes
Copy link
Member

@ekrich ekrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want SafepointInsertion commented out?

@densh
Copy link
Member Author

densh commented May 8, 2017 •
edited

@ekrich SafepointInsertion is commented out in the list of passes due to the fact that our current GC doesn't need it. It's going to be enabled later in the future PR that introduces new concurrent collector.

@ekrich
Copy link
Member

ekrich commented May 8, 2017

I thought it was deliberate but wasn't sure, thanks.

@densh densh merged commit 89b08f8 into scala-native:master May 9, 2017
muxanick pushed a commit to muxanick/scala-native that referenced this pull request May 25, 2017
@densh @muxanick
Preliminary support for segfault-based safepoints (scala-native#711)
0f5e3e9 
* Add support for volatile loads and stores to NIR

* Add support for alignment attribute

* Preliminary support for segfault-based safepoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekrich ekrich ekrich left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@densh @DarkDimius @ekrich