Add scopes to the tasks defined by the sbt plugin #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas
reviewed
May 9, 2017
| @@ -235,18 +236,18 @@ object ScalaNativePluginInternal { | |||
| logger.running(compilec) | |||
| val result = Process(compilec, cwd) ! logger | |||
| if (result != 0) { | |||
| println("Failed to compile native library runtime code.") | |||
| sys.error("Failed to compile native library runtime code.") | |||
There was a problem hiding this comment.
Yup, I mentioned it in the commit message, but forgot to in the PR description. Thanks!
There was a problem hiding this comment.
Note that sys.error will be deprecated in 2.13: scala/scala#5677. It's better to use throw new RuntimeException instead.
|
The changes look good to me! 👍 |
Duhemm
force-pushed
the
topic/task-scoping
branch
from
3566d1a
to
1413c57
Compare
|
Done! |
|
Maybe there is a regression or change specification of |
|
@xuwei-k Do you have an example of project that shows this behavior? I can't reproduce it on the |
Duhemm
added a commit
to Duhemm/scala-native
that referenced
this pull request
May 19, 2017
It was incorrectly unscoped since scala-native#714
muxanick
pushed a commit
to muxanick/scala-native
that referenced
this pull request
May 25, 2017
* Scope Scala Native's tasks to `Compile` and `Test` * Report native lib compilation failures * Adapt scripted tests to scoping changes * Remove unused imports Fixes scala-native#692
Duhemm
added a commit
to Duhemm/scala-native
that referenced
this pull request
Jun 9, 2017
It was incorrectly unscoped since scala-native#714
densh
pushed a commit
that referenced
this pull request
Jun 9, 2017
|
|
@xuwei-k Can you please file an issue for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to the scripted tests may be seen as a problem, but they are actually correct. The following build definition would fail at runtime, saying that there are undefined settings:
Also, fixes #692