Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to update semanticdbVersion defined in build.sbt #1514

Open
exoego opened this issue Jul 1, 2020 · 1 comment
Open

Ability to update semanticdbVersion defined in build.sbt #1514

exoego opened this issue Jul 1, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@exoego
Copy link
Contributor

exoego commented Jul 1, 2020

This idea came up on my mind on scalacenter/scalafix#1183

sbt-scalafix automatically downloads semanticdb-scalac specified by semanticdbVersion property.
sbt-scalafix defines the default semanticdb-scalac version in scalafixSemanticdb.revision property.
However, sometimes the scalameta version in scalafixSemanticdb.revision is incompatible with newer Scala.
So, users may need to set semanticdbVersion explicitly , like below:

inThisBuild(
  List(
    semanticdbEnabled := true,
    // semanticdbVersion := scalafixSemanticdb.revision, 
    semanticdbVersion := "4.3.18", 
    Configs.isProductionRelease := false
  )
)

However, this is not good since the version need manual update when newer version of scalameta/sbt-scalafix are published.

I think Scala Steward can save such manual updating semanticdbVersion, like doing so on scalafmt or sbt.

@fthomas
Copy link
Member

fthomas commented Jul 2, 2020

Sounds good to me. Should we wait until scalacenter/scalafix#1146 is resolved? If I understand that correctly it will be possible in the future to set the Scalafix version (and therefore the semanticdb version) in .scalafix.conf similar to how the Scalafmt version is set in .scalafmt.conf. The implementation for this feature could then be similar to the existing implementation for Scalafmt.

@fthomas fthomas added the enhancement New feature or request label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants