Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hardcode sbt-scalafix version #2357

Closed
fthomas opened this issue Nov 15, 2021 · 1 comment · Fixed by #2475
Closed

Do not hardcode sbt-scalafix version #2357

fthomas opened this issue Nov 15, 2021 · 1 comment · Fixed by #2475
Labels
enhancement New feature or request

Comments

@fthomas
Copy link
Member

fthomas commented Nov 15, 2021

We currently hardcode the version of sbt-scalafix that we add to the global sbt plugins temporarily while applying Scalafix migrations:

"""addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.9.32")"""

This is not ideal for Scala Steward instances that do not track the latest changes from this repository. If a new sbt-scalafix version is released that supports newer Scala versions, Scala Steward instances that not yet include that latest sbt-scalafix version might not successfully apply Scalafix migrations in projects that are already on the new Scala version. I think it would be better to use the latest sbt-scalafix version from the VersionsCache.

@fthomas fthomas added the enhancement New feature or request label Nov 15, 2021
@bjaglin
Copy link
Contributor

bjaglin commented Mar 26, 2022

With the upcoming scalacenter/sbt-scalafix#292, scalafixEnable will be able to work with future Scala versions (i.e. published after the release of the sbt-scalafix running). I am wondering if it's not better to revert this change for the sake of a more deterministic behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants