Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a link to the upgraded project in the PR #82

Closed
ennru opened this issue Oct 11, 2018 · 6 comments · Fixed by #762
Closed

Include a link to the upgraded project in the PR #82

ennru opened this issue Oct 11, 2018 · 6 comments · Fixed by #762
Labels
enhancement New feature or request

Comments

@ennru
Copy link
Contributor

ennru commented Oct 11, 2018

... in a perfect world to its release notes.

@fthomas fthomas added the enhancement New feature or request label Oct 12, 2018
@fthomas
Copy link
Member

fthomas commented Oct 12, 2018

Good idea, @ennru. Do you have an idea how to obtain the URL of the website or the release notes from maven coordinates (groupId,artifactId, and a version) because currently that is the only thing the bot knows about a dependency. Any suggestions are welcome.

@SethTisue
Copy link
Contributor

SethTisue commented Oct 12, 2018

I think you'd have to use Scaladex as your information source, Scaladex knows this kind of thing

/cc @MasseGuillaume

@ennru
Copy link
Contributor Author

ennru commented Oct 12, 2018

Do you have access to the pom.xml? If the SCM section points to Github, you could point to the Releases tab.

@fthomas
Copy link
Member

fthomas commented Jun 14, 2019

sbt-updates does not download the pom.xml but only the maven-metadata.xml which just contains the versions. But I could fetch the pom.xml with coursier via coursier fetch -A pom $groupId:$artifactId:$version. This should work for all public dependencies.

@mwz
Copy link
Contributor

mwz commented Jul 3, 2019

It would be great if scala-steward could include release notes in the description of the PR, similarly to how dependabot does it - see the screenshot below for a reference:

Screenshot 2019-07-03 at 16 39 29

This data is fetched from Github releases, so we could use it for projects which use this feature and provide any release notes. This feature would be quite cool, I'd be happy to contribute this if that's something you would be keen on having in scala-steward, @fthomas.

@fthomas
Copy link
Member

fthomas commented Jul 3, 2019

That would be awesome, @mwz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants