Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all release related links in PR body #1308

Merged

Conversation

kiranbayram
Copy link
Contributor

Adresses #1285

@fthomas
Copy link
Member

fthomas commented Feb 10, 2020

Many thanks, @kiranbayram! Running sbt fmt should get the build past fmtCheck.

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #1308 into master will increase coverage by 0.29%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1308      +/-   ##
==========================================
+ Coverage   68.01%   68.31%   +0.29%     
==========================================
  Files          99       99              
  Lines        1532     1537       +5     
  Branches       38       42       +4     
==========================================
+ Hits         1042     1050       +8     
+ Misses        490      487       -3
Impacted Files Coverage Δ
...ala/org/scalasteward/core/nurture/NurtureAlg.scala 9.47% <0%> (+0.19%) ⬆️
...calasteward/core/vcs/data/NewPullRequestData.scala 100% <100%> (ø) ⬆️
.../scala/org/scalasteward/core/vcs/VCSExtraAlg.scala 100% <100%> (+33.33%) ⬆️
...main/scala/org/scalasteward/core/vcs/package.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84dd85e...11a43a8. Read the comment docs.

@fthomas fthomas added this to the 0.6.0 milestone Feb 10, 2020
@fthomas fthomas added the enhancement New feature or request label Feb 10, 2020
Copy link
Member

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, many thanks @kiranbayram!

@fthomas fthomas merged commit 62f6a2b into scala-steward-org:master Feb 10, 2020
@kiranbayram kiranbayram deleted the changelog-url-refactoring branch February 10, 2020 19:08
@fthomas fthomas linked an issue Feb 10, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include changelog AND release notes in PR body
2 participants