Change default value of --disable-sandbox #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the default value of the `--disable-sandbox` option from `false` to `true`. I think this is a better default since sandboxed execution is only useful when the operator of Scala Steward does not trusts the repositories it is working on. This is only true for public instances and (almost) never true for private instances. And there are a lot more private than public instances. Other arguments for this change are that `firejail` does not work inside Docker and that documentation and setup become simpler. To enable sandboxed execution, `--disable-sandbox=false` or the newly added `--enable-sandbox` option can be used.
Codecov Report
@@ Coverage Diff @@
## master #1719 +/- ##
=======================================
Coverage 73.99% 73.99%
=======================================
Files 115 115
Lines 1957 1957
Branches 55 50 -5
=======================================
Hits 1448 1448
Misses 509 509
Continue to review full report at Codecov.
|
xuwei-k
reviewed
Nov 8, 2020
| @@ -118,7 +118,7 @@ object Config { | |||
| sandboxCfg = SandboxCfg( | |||
| whitelistedDirectories = args.whitelist, | |||
| readOnlyDirectories = args.readOnly, | |||
| disableSandbox = args.disableSandbox | |||
| enableSandbox = args.enableSandbox.getOrElse(args.disableSandbox) | |||
There was a problem hiding this comment.
🤔
- enableSandbox = args.enableSandbox.getOrElse(args.disableSandbox)
+ enableSandbox = args.enableSandbox.getOrElse(!args.disableSandbox)There was a problem hiding this comment.
🤦 Of course! Thanks for noticing! If you want to, you can submit a PR changing this. Or I'll do it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default value of the
--disable-sandboxoption fromfalsetotrue. I think this is a better default since sandboxedexecution is only useful when the operator of Scala Steward does not
trusts the repositories it is working on. This is only true for public
instances and (almost) never true for private instances. And there are
a lot more private than public instances.
Other arguments for this change are that
firejaildoes not work insideDocker and that documentation and setup become simpler.
To enable sandboxed execution,
--disable-sandbox=falseor the newlyadded
--enable-sandboxoption can be used.