Fixed throwing StringIndexOutOfBoundsException #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… duplicated replacements are used to edit the file. In other words, trying to replace single dependency more than once which is not valid.
Seetaramayya
commented
Mar 20, 2023
modules/core/src/test/scala/org/scalasteward/core/edit/RewriteTest.scala
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3016 +/- ##
=======================================
Coverage 91.09% 91.09%
=======================================
Files 160 160
Lines 3336 3336
Branches 306 303 -3
=======================================
Hits 3039 3039
Misses 297 297
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
fthomas
approved these changes
Mar 24, 2023
Seetaramayya
commented
Mar 24, 2023
| @@ -432,6 +431,17 @@ class RewriteTest extends FunSuite { | |||
| runApplyUpdate(update, original, expected) | |||
| } | |||
|
|
|||
| // https://github.com/scala-steward-org/scala-steward/pull/3016 | |||
| test("artifact change with multiple artifactId cross names") { | |||
mzuehlke
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue that is throwing StringIndexOutOfBoundsException when duplicated replacements are used to edit the file.
In other words, trying to replace single dependency more than once which is not valid.