Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset instead of merge to update branches #3219

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Reset instead of merge to update branches #3219

merged 1 commit into from
Nov 23, 2023

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Nov 22, 2023

Closes #3218

@fthomas fthomas added the enhancement New feature or request label Nov 22, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (43c917d) 91.07% compared to head (1fe2aab) 91.08%.

Files Patch % Lines
...ala/org/scalasteward/core/nurture/NurtureAlg.scala 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3219   +/-   ##
=======================================
  Coverage   91.07%   91.08%           
=======================================
  Files         163      163           
  Lines        3407     3386   -21     
  Branches      310      303    -7     
=======================================
- Hits         3103     3084   -19     
+ Misses        304      302    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alejandrohdezma
alejandrohdezma approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@alejandrohdezma alejandrohdezma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would make daily life of reviewers a lot easier! 🎉

@fthomas fthomas merged commit 1d78397 into main Nov 23, 2023
9 of 10 checks passed
@fthomas fthomas added this to the 0.28.0 milestone Nov 23, 2023
@fthomas fthomas deleted the topic/reset-update-branches branch November 23, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrohdezma alejandrohdezma alejandrohdezma approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.

Update branches via reset instead of reverting changes
2 participants
@fthomas @alejandrohdezma