Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to mdoc from tut #542

Merged
merged 1 commit into from
Mar 14, 2020
Merged

migrate to mdoc from tut #542

merged 1 commit into from
Mar 14, 2020

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Feb 29, 2020

まだWIP

https://scala-text.github.io/scala_text_previews/mdoc/

TODO:

  • lintでscalaコードの def foo[A](x: Int) みたいなのをmarkdownのリンクだと解釈してしまってURL ファイルの存在チェックをしてしまって、lintが通らない
  • mdoc:fail の場合に、以前の関係ないコンパイルエラーまで全部表示されてる?

@kmizu
Copy link
Contributor

kmizu commented Feb 29, 2020

@xuwei-k Fix面倒そうなら、この機会に、いっそlint削ってもいいのではとか思い始めてます(あるいは、もうちょっとルールを緩くするとか)。 >lintでscalaコードの def foo[A](x: Int) みたいなのをmarkdownのリンクだと解釈してしまって

@xuwei-k
Copy link
Contributor Author

xuwei-k commented Feb 29, 2020

tutのときはなんでそう解釈されてなかったのか謎というか調べてないので調べるかなぁ…

@xuwei-k xuwei-k force-pushed the mdoc branch 5 times, most recently from 0707a72 to 612c949 Compare March 14, 2020 07:59
@xuwei-k xuwei-k changed the title [WIP] migrate to mdoc from tut migrate to mdoc from tut Mar 14, 2020
@xuwei-k
Copy link
Contributor Author

xuwei-k commented Mar 14, 2020

  • mdoc:fail の問題は、たんに scala にして、"失敗することのチェックを一旦諦める" とした。
  • scalaコードをmarkdownのリンクとして解釈する問題は、JavaScript直した

@xuwei-k xuwei-k marked this pull request as ready for review March 14, 2020 08:09
@xuwei-k xuwei-k requested a review from kmizu as a code owner March 14, 2020 08:09
@xuwei-k xuwei-k merged commit da418ad into master Mar 14, 2020
@xuwei-k xuwei-k deleted the mdoc branch March 14, 2020 08:15
xuwei-k added a commit to scala-text/scala_text_pdf that referenced this pull request Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants