Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridBagPanel is inflexible #136

Open
scabug opened this issue Dec 13, 2010 · 1 comment
Open

GridBagPanel is inflexible #136

scabug opened this issue Dec 13, 2010 · 1 comment

Comments

@scabug
Copy link

scabug commented Dec 13, 2010

Suggested changes:

  • Constraints should be a member of the companion object rather than the class, as there's no reason to tie constraint construction to a particular panel instance.

  • The add method should not be protected. That may have made sense if GridBagPanel is to be used only declaratively, but arguably this layout is too complex for that. Rather, it's a prime candidate for wrapping by some application-specific declarative framework, in which case the protection is just a pain.

  • The single mutating constraints object as used in the demo code is nasty. Ideally Constraints should be a case class with keyword arguments.

@scabug
Copy link
Author

scabug commented Dec 13, 2010

Imported From: https://issues.scala-lang.org/browse/SI-4078?orig=1
Reporter: Jamie Webb (jmawebb)

@scabug scabug closed this as completed Jul 17, 2015
@SethTisue SethTisue transferred this issue from scala/bug Nov 19, 2020
@SethTisue SethTisue reopened this Nov 19, 2020
@scala scala deleted a comment from scabug Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants