Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JDK 17 build #1432

Closed
8 of 9 tasks
SethTisue opened this issue Jun 16, 2021 · 8 comments
Closed
8 of 9 tasks

add JDK 17 build #1432

SethTisue opened this issue Jun 16, 2021 · 8 comments
Assignees
Labels

Comments

@SethTisue
Copy link
Member

SethTisue commented Jun 16, 2021

(...and drop 16, presumably)

JDK 17 is now feature-complete and the final release lands in September, so now is a good time for this

The current JDK 17 build is "Build 26 (2021/6/11)".

using #1352 as a guide to steps needed:

  • on all 3 behemoths:
    • cd /usr/lib/jvm
    • sudo curl -O -L 'https://download.java.net/java/early_access/jdk17/26/GPL/openjdk-17-ea+26_linux-x64_bin.tar.gz'
    • sudo dtrx -n openjdk-17-ea+26_linux-x64_bin.tar.gz
    • sudo rm openjdk-17-ea+26_linux-x64_bin.tar.gz
    • sudo chmod -R go+rX openjdk-17-ea+26_linux-x64_bin
    • sudo ln -s openjdk-17-ea+26_linux-x64_bin java-17-openjdk-x64
    • ./java-17-openjdk-x64/jdk-17/bin/java -version
  • add -jdk17- jobs (on 2.12.x and 2.13.x) with JDK version set appropriately
  • make sure both jobs extract
  • make sure both jobs have at least a green core
  • update scripts/Report.scala (both branches)
  • report selected failures upstream
  • open a separate ticket on gradually getting more projects green?
  • disable the old -jdk16- jobs
  • delete the old -jdk16- workspace directories
@SethTisue SethTisue self-assigned this Jun 16, 2021
@lrytz
Copy link
Member

lrytz commented Jun 17, 2021

👍 thank you, this is the perfect time to start testing 17.

@fernandoracca
Copy link

this is great! looking forward to start using the newer JVMs.

@SethTisue
Copy link
Member Author

SethTisue commented Jun 21, 2021

2.13.x core is green. I will dig into the specific failures

2.12.x core fails with some lambda deserialization problem. I've opened a separate ticket on it: scala/bug#12419

@SethTisue
Copy link
Member Author

SethTisue commented Jun 22, 2021

Jason fixed the deserialization thing, so the 2.12.x core is now green too (on 2.12.15-bin-b2b8816)

@SethTisue
Copy link
Member Author

SethTisue commented Jun 22, 2021

2.13.x status as of this run: FAILURES (UNEXPECTED): akka-http,akka-more,macwire,classutil

all four repos are running afoul of https://openjdk.java.net/jeps/403, resulting in java.lang.reflect.InaccessibleObjectExceptions

I will mark them as expected-to-fail.

I suspect it would be possible for me to make them pass by replacing --illegal-access=... with the more specific --add-opens, but in general, it's not a priority for us to get out ahead of upstream maintainers on JDK 17 support once the overall number of green projects seems adequate for QAing Scala itself.

@patriknw
Copy link

Thanks @SethTisue .
I have created issues akka/akka-http#3852 and akka/akka#30341

@SethTisue
Copy link
Member Author

declaring victory here. we'll want to ship 2.12.15 before too much longer, in order to get the serialization fix out

@SethTisue
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants