-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scalaz-zio (and remove scalaz 8 for now) #831
Conversation
@SethTisue Woohoo! 🕺 🎉 Let me know if there's anything I can / should do. |
@jdegoes will do. new run, after needed tweak to config: |
hmm
not sure why dbuild seems to think jcstress is a Scala-based dependency, subject to version number rewriting. it's Java-based, dbuild should be leaving it alone. I'll have to take a closer look at this later |
a similar thing occurs with sbt-jmh. something about sbt plugins that modify |
c6f63ad
to
832d71c
Compare
the good news is that the core, and some of the integration subprojects, are already green in local testing but this is failing:
it's in right now I don't know yet what might be causing this |
let's just drop
|
status report: in the last test run, scalaz-zio itself was green (with I could have worked around it by building pascal twice, once in each space, but I'd like to rethink all this instead, as follows. at the time I added scalaz 8 to the community build, circa May 2018, it was actually mainly because I wanted to include scalaz-effect, which was starting to get some traction. but scalaz-effect became scalaz-zio (and doesn't depend on scalaz 8), and scalaz 8 hasn't seen a ton of development action lately, and I haven't seen other projects start to depend on it, so I don't think it's currently worth keeping if it must be in its own dbuild space, since multiple spaces complicates everything (as we see with the pascal issue). so what I've done in the latest wip commit is moved scalaz 8 into the same space with scalaz 7 and scalaz-zio. if that works out, great. but if this approach proves impossible, or just too hard, I'll just drop scalaz 8 for now. we could always bring it back later. new run queued: |
I can delete |
Btw thanks for your work on this and sorry it's been such a pain! |
yes please!
no worries, it's pretty much always like this, here in this repo :-) |
I went ahead and removed scalaz 8 for now, see #843, any further discussion on that aspect can go there |
Too late to help, perhaps, but we deleted Pascal too! Looks like a holdover from when ZIO was copied over from Scalaz 8. |
fyi @jdegoes