Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SetMapRulesTest, based on 2.13.3 experience #713

Closed
SethTisue opened this issue Jun 23, 2020 · 1 comment
Closed

Improve SetMapRulesTest, based on 2.13.3 experience #713

SethTisue opened this issue Jun 23, 2020 · 1 comment
Assignees
@SethTisue
Milestone
Backlog

Comments

@SethTisue
Copy link
Member

SethTisue commented Jun 23, 2020 •
edited

splitting this off from as a post-release to-do item, from scala/scala#9078
@SethTisue SethTisue self-assigned this Jun 23, 2020
@SethTisue SethTisue mentioned this issue Jun 23, 2020
Merged
@dwijnand dwijnand added this to the Backlog milestone Oct 19, 2020
@SethTisue
Copy link
Member Author

SethTisue commented Oct 21, 2020 •
edited

@lrytz I'm finally looking at this, after a long delay...

you wrote:

Add a generic test case to SetMapRulesTest that would have caught the bug before we found it in scala-collections-laws.

now that I'm looking at this again, I guess I don't understand why this is necessary (or worth the effort). we have scala-collection-laws, and we always run it before release. in principle, anything in scala-collection-laws could also be duplicated in scala/scala. I don't see how doing that piecemeal makes sense.

admittedly it would be nice if we had some more convenient, automatic way to run scala-collection-laws on a PR besides manually queueing up a Jenkins run. we have a ticket on it, even: #411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@SethTisue @dwijnand