Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groupMapReduce to Iterator #8

Closed
sim642 opened this issue Dec 3, 2019 · 6 comments · Fixed by #23
Closed

Add groupMapReduce to Iterator #8

sim642 opened this issue Dec 3, 2019 · 6 comments · Fixed by #23
Labels
enhancement New feature or request library:collections status:pending This enhancement request lacks consensus on whether or not to include it

Comments

@sim642
Copy link

sim642 commented Dec 3, 2019

Currently groupMapReduce is defined in IterableOps so it's not available for Iterator, but it easily could be because it doesn't require building an inner collection of the collection type, unlike groupBy and groupMap. Thus groupMapReduce would be hoisted to IterableOnceOps instead and be a consuming operation on the iterator.

I suppose the current workaround would be to use to(LazyList) on an iterator and use groupMapReduce on that.

@NthPortal
Copy link
Contributor

not fixable in 2.13. should be transferred to scala/scala-library-next for sooner fix

@NthPortal
Copy link
Contributor

NthPortal commented Nov 20, 2020

everyone okay with this change? (👍 in favour, 👎 against)

@NthPortal NthPortal added enhancement New feature or request status:pending This enhancement request lacks consensus on whether or not to include it labels Nov 21, 2020
@NthPortal
Copy link
Contributor

it has been about 2 weeks, with moderate explicit support and no dissent. if there is no dissent by this coming Sunday (2020-12-06), or if we get a couple lightbend approvals before then (without any dissenting opinions), I will consider this proposal accepted.

obviously, we can still come back to it at any later point before release and change things if we decide to

@SethTisue
Copy link
Member

SethTisue commented Dec 7, 2020

I will consider this proposal accepted

Note that I think we should probably hold off on actually merging any PRs here until we have some kind of signoff process. I made a ticket on it: #52

@NthPortal
Copy link
Contributor

as context for the fact that I merged this anyway, this comment by Seth in Gitter; I think this is a fairly uncontroversial change, as it just moves the method up the collections hierarchy

@SethTisue
Copy link
Member

Yeah, that's fine. We can handle things on a case by case basis until we have something written down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request library:collections status:pending This enhancement request lacks consensus on whether or not to include it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants