Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release for Scala 2.13.0-M2 #124

Closed
xuwei-k opened this issue Jul 29, 2017 · 10 comments
Closed

release for Scala 2.13.0-M2 #124

xuwei-k opened this issue Jul 29, 2017 · 10 comments

Comments

@xuwei-k
Copy link
Contributor

xuwei-k commented Jul 29, 2017

No description provided.

@lrytz
Copy link
Member

lrytz commented Jul 31, 2017

git tag -s -m "1.0.6 for 2.13.0-M2" v1.0.6#2.13.0-M2#8 65802b5c91798609f6ac4fca136365d61607c031
git push upstream v1.0.6#2.13.0-M2#8

Build running here: https://travis-ci.org/scala/scala-parser-combinators/builds/259264349

@lrytz
Copy link
Member

lrytz commented Jul 31, 2017

[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: org.scala-js#scalajs-library_2.13.0-M2;0.6.16: not found
[warn] 	:: org.scala-js#scalajs-test-interface_2.13.0-M2;0.6.16: not found
[warn] 	:: org.scala-js#scalajs-junit-test-runtime_2.13.0-M2;0.6.16: not found
[warn] 	:: org.scala-js#scalajs-compiler_2.13.0-M2;0.6.16: not found
[warn] 	:: org.scala-js#scalajs-junit-test-plugin_2.13.0-M2;0.6.16: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::

0.6.16 is not released against 2.13.0-M2, but 0.6.19 is there. So this requires an update to the build.sbt. I'm not sure if it's ok push a new commit on top of 65802b5 and tag that as v1.0.6#2.13.0-M2#8? That would be a tag that's not part of the 1.0.x branch (or any other branch).

@milessabin
Copy link
Contributor

This is blocking me releasing shapeless for 2.13.0-M2 ...

@SethTisue
Copy link
Member

@lrytz seems fine to me

@lrytz
Copy link
Member

lrytz commented Aug 2, 2017

http://repo1.maven.org/maven2/org/scala-lang/modules/scala-parser-combinators_2.13.0-M2/1.0.6/

Note that only the JVM version works, the _sjs0.6 jar is still empty in this release (#119). This will be fixed in 1.0.7.

@lrytz lrytz closed this as completed Aug 2, 2017
@milessabin
Copy link
Contributor

I think that's still blocks me releasing. I would have branched and bumped the sjs version.

@lrytz
Copy link
Member

lrytz commented Aug 2, 2017

I did bump the sjs version: diff

Why does it block you? The release is equivalent to what we had for 2.13.0-M1.

@milessabin
Copy link
Contributor

Oh, sorry, I misunderstood. In that case why is the _sjs0.6 jar empty?

In any case, I was wrong about this blocking a shapeless release :-)

@lrytz
Copy link
Member

lrytz commented Aug 2, 2017

See #119

@milessabin
Copy link
Contributor

Gotcha ... thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants