Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically publish artifacts for PRs #6145

Open
smarter opened this issue Mar 22, 2019 · 4 comments
Open

Automatically publish artifacts for PRs #6145

smarter opened this issue Mar 22, 2019 · 4 comments

Comments

@smarter
Copy link
Member

smarter commented Mar 22, 2019

Right now, testing the effect of a PR against an external project requires checking out that PR and publishing it locally, it'd be great if we automatically published artifacts for PRs just like what's done in scala/scala.
@SethTisue: Is there documentation on how this is accomplished ?

@SethTisue
Copy link
Member

it happens via https://github.com/scala/scala/blob/2.13.x/scripts/jobs/validate/publish-core , it basically just calls publish...

...with an appropriate version number that includes the 7-character SHA. the logic for that is in https://github.com/scala/scala/blob/2.13.x/project/VersionUtil.scala

there is discussion at scala/scala-dev#495 over whether to append -SNAPSHOT or not (mostly leaning towards "we shouldn't", though we still do)

happy to answer any followup questions

@SethTisue
Copy link
Member

SethTisue commented Mar 25, 2019

note that we publish from a Jenkins which is configured with the appropriate publishing secrets, so we don't hit Travis-CI's restriction about PR jobs not being allowed to have secrets

we'd have to clear that hurdle somehow if we ditch Jenkins for Travis-CI. but it's increasingly unclear whether we will do so

@smarter
Copy link
Member Author

smarter commented Mar 29, 2019

@SethTisue @adriaanm Do you think it could be possible for us to reuse https://scala-ci.typesafe.com/artifactory/scala-integration/ to publish dotty PR snapshots ?

@adriaanm
Copy link
Contributor

adriaanm commented Apr 1, 2019

sure -- could you email me with a preferred username + email for the account?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants