Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advance the support for Scala.js #7113

Closed
sjrd opened this issue Aug 27, 2019 · 8 comments
Closed

Advance the support for Scala.js #7113

sjrd opened this issue Aug 27, 2019 · 8 comments
Labels
area:scala.js exp:novice help wanted
Milestone
3.0.0-M1

Comments

@sjrd
Copy link
Member

sjrd commented Aug 27, 2019

Dotty contains preliminary support for Scala.js under the flag -scalajs. Or rather, it contains the infrastructure for preliminary support. It is far from being actually usable, but this is where you can help!

I have written a tutorial that walks you through a few steps that you can do to further the support of Scala.js in Dotty. Even if you do not typically contribute to a compiler, this can be your chance. It is not very difficult, given that there already exists an extensive test suite, as well as a working implementation for scalac.

Read the tutorial, and get going!
@anatoliykmetyuk anatoliykmetyuk added this to the 0.18 Tech Preview milestone Aug 28, 2019
@cquiroz cquiroz mentioned this issue Aug 28, 2019
Merged
@cquiroz
Copy link
Contributor

cquiroz commented Aug 28, 2019

I noted that often when adding and then removing a test suite I'd get errors like it was still trying to compile the removed test suite

I solved it by explicitly deleting the files with
rm -Rf tests/out/bootstrap/sjsJUnitTests

@neshkeev
Copy link
Contributor

The following two tests from javalib.lang fail without dotty alteration (the rest of the tests from the package are added in #7255):

  1. javalib/lang/ClassTest.scala: error log link
  2. javalib/lang/StringTest.scala: error log link

@neshkeev
Copy link
Contributor

neshkeev commented Sep 19, 2019 •
edited
Loading

The following tests from javalib.io fail without dotty alteration (only three tests from javalib.io are successful so far #7271)

  1. javalib/io/ByteArrayInputStreamTest.scala: error log link
  2. javalib/io/ByteArrayOutputStreamTest.scala: error log link
  3. javalib/io/DataInputStreamTest.scala: error log link
  4. javalib/io/DataOutputStreamTest.scala: error log link
  5. javalib/io/InputStreamTest.scala: error log link
  6. javalib/io/OutputStreamWriterTest.scala: error log link
  7. javalib/io/PrintStreamTest.scala: error log link
  8. javalib/io/ReadersTest.scala: error log link

@neshkeev
Copy link
Contributor

neshkeev commented Sep 19, 2019 •
edited
Loading

All the tests from javalib.math have been enabled, no failing tests were discovered #7272

@neshkeev
Copy link
Contributor

neshkeev commented Sep 19, 2019 •
edited
Loading

The following test from the javalib.net fails:

  1. javalib/net/URITest.scala: error log link

The second test in the group javalib/net/URLDecoderTest.scala has been enabled #7273

@Lacaranian
Copy link
Contributor

Lacaranian commented Oct 6, 2019 •
edited
Loading

I may dig into that URITest failure.

Edit: Looking at some of the other failures as well.

@neshkeev
Copy link
Contributor

neshkeev commented Oct 6, 2019

@Lacaranian , good, please do it

Lacaranian referenced this issue in Lacaranian/dotty Oct 7, 2019
@Lacaranian
Issue lampepfl#7113: Enable javalib/net/URITest for Scala.js
43371f9 
- Fix an issue where non-null parameters with default arguments of null
  would generate default parameter functions returning a type of null,
  which is unknown to the ScalaJS backend. Use the type of the non-null
  parameter as the return type
- Enable the URITest for Scala.js, which was blocked by the previous
  issue
Lacaranian referenced this issue in Lacaranian/dotty Oct 8, 2019
@Lacaranian
Issue lampepfl#7113: Enable javalib/net/URITest for Scala.js
8524440 
- Fix the encoding of the NullClass and NothingClass in JSEncoding to
  correctly map to the corresponding Scala.js IR Symbols
- Enable the URITest for Scala.js, which was blocked by the previous
  issue
@sjrd sjrd mentioned this issue Oct 9, 2019
Closed
Lacaranian referenced this issue in Lacaranian/dotty Oct 13, 2019
@Lacaranian
Issue lampepfl#7113: Enable javalib/net/URITest for Scala.js
fa94fa1 
- Fix the encoding of the NullClass and NothingClass in JSEncoding to
  correctly map to the corresponding Scala.js IR Symbols
- Enable the URITest for Scala.js, which was blocked by the previous
  issue
Lacaranian referenced this issue in Lacaranian/dotty Oct 13, 2019
@Lacaranian
Issue lampepfl#7113: Enable javalib/lang/ClassTest for Scala.js
9936571 
- Fix an issue where BoxedUnit's TYPE member was not being correctly
  rewritten as java.lang.Void in Scala.js IR
- Enable the ClassTest for Scala.js, which uses the
  scala.runtime.BoxedUnit.TYPE value in one of its tests
Lacaranian referenced this issue in Lacaranian/dotty Oct 13, 2019
@Lacaranian
Issue lampepfl#7113: Enable javalib/lang/ClassTest for Scala.js
6fd1274 
- Fix an issue where BoxedUnit's TYPE member was not being correctly
  rewritten as java.lang.Void in Scala.js IR
- Enable the ClassTest for Scala.js, which uses the
  scala.runtime.BoxedUnit.TYPE value in one of its tests
Lacaranian referenced this issue in Lacaranian/dotty Oct 13, 2019
@Lacaranian
Issue lampepfl#7113: Enable javalib/lang/ClassTest for Scala.js
31853ba 
- Fix an issue where BoxedUnit's TYPE member was not being correctly
  rewritten as java.lang.Void in Scala.js IR
- Enable the ClassTest for Scala.js, which uses the
  scala.runtime.BoxedUnit.TYPE value in one of its tests
Lacaranian referenced this issue in Lacaranian/dotty Oct 13, 2019
@Lacaranian
Issue lampepfl#7113: Fix Scala.js codegen for BoxedUnit.TYPE
1d15a39 
- `scala.runtime.BoxedUnit.TYPE` is now intercepted by `JSCodeGen` as a
  primitive for `ClassOf(ClassRef("V"))`, which Scala.js recognizes as
  `java.lang.Void`
- Enable the javalib/lang/ClassTest for Scala.js, which contains a test
  that uses `BoxedUnit.TYPE`
Lacaranian referenced this issue in Lacaranian/dotty Oct 13, 2019
@Lacaranian
Issue lampepfl#7113: Enable javalib/net/URITest for Scala.js
c9f237d 
- Fix the encoding of the NullClass and NothingClass in JSEncoding to
  correctly map to the corresponding Scala.js IR Symbols
- Enable the URITest for Scala.js, which was blocked by the previous
  issue
Lacaranian referenced this issue in Lacaranian/dotty Oct 13, 2019
@Lacaranian
Issue lampepfl#7113: Fix Scala.js codegen for Null/Nothing types
1e3d1ce 
- Fix the encoding of the `NullClass` and `NothingClass` in `JSEncoding` to
  correctly map to the corresponding Scala.js IR Symbols
- Enable the `javalib/net/URITest` for Scala.js, which uses default
  arguments with `null` values, which in turn are used as the return
  type of the default getters.
Lacaranian referenced this issue in Lacaranian/dotty Oct 21, 2019
@Lacaranian
Issue lampepfl#7113: Fix Scala.js codegen for Tail Recursive Returns
2ad91c1 
In order to return from a tail recursive tree in Scala.js IR, a label
must be placed outside the loop to serve as a jump/break point. While
a fresh return label had been generated for such methods (in the
LocalNameGenerator), it had not been placed at the top level of its
method, and was otherwise unused.

After generating a method's body, if a enclosing return label had been
generated, use it to wrap the method body (just as Scala 2's JS codegen
does) for such breaks.

Enable the tests of ReadersTest.scala of the Scala.js test suite, of
which InputStreamReaderTest used a tail-recursive method that depended
on this fix.
Lacaranian referenced this issue in Lacaranian/dotty Oct 22, 2019
@Lacaranian
Issue lampepfl#7113: Fix Scala.js codegen for Explicit Returns
3f43614 
In order to use an explicit return statement in Scala.js IR, a label
must be placed wrapping the whole function body to serve as a jump/break
point for all control structures inside the function. While a fresh return
label had been generated for such methods (in the LocalNameGenerator),
it had not been placed at the top level of its method, and was otherwise
unused. This affected the tree created by the TailRec MiniPhase, as well
as user-written early return statements.

After generating a method's body, if a enclosing return label had been
generated, use it to wrap the method body (just as Scala 2's JS codegen
does) for such breaks.

Enable the tests of ReadersTest.scala of the Scala.js test suite, of
which InputStreamReaderTest used a tail-recursive method that depended
on this fix.
Lacaranian referenced this issue in Lacaranian/dotty Oct 22, 2019
@Lacaranian
Partial fix for lampepfl#7113: Fix Scala.js codegen for Explicit Returns
00d4216 
In order to use an explicit return statement in Scala.js IR, a label
must be placed wrapping the whole function body to serve as a jump/break
point for all control structures inside the function. While a fresh return
label had been generated for such methods (in the LocalNameGenerator),
it had not been placed at the top level of its method, and was otherwise
unused. This affected the tree created by the TailRec MiniPhase, as well
as user-written early return statements.

After generating a method's body, if a enclosing return label had been
generated, use it to wrap the method body (just as Scala 2's JS codegen
does) for such breaks.

Enable the tests of ReadersTest.scala of the Scala.js test suite, of
which InputStreamReaderTest used a tail-recursive method that depended
on this fix.
Lacaranian referenced this issue in Lacaranian/dotty Oct 22, 2019
@Lacaranian
Partial fix for lampepfl#7113: Fix Scala.js codegen for Null/Nothing …
d080e9f 
…types

- Fix the encoding of the `NullClass` and `NothingClass` in `JSEncoding` to
  correctly map to the corresponding Scala.js IR Symbols
- Enable the `javalib/net/URITest` for Scala.js, which uses default
  arguments with `null` values, which in turn are used as the return
  type of the default getters.
Lacaranian referenced this issue in Lacaranian/dotty Oct 22, 2019
@Lacaranian
Partial fix for lampepfl#7113: Fix Scala.js codegen for BoxedUnit.TYPE
a070ef8 
- `scala.runtime.BoxedUnit.TYPE` is now intercepted by `JSCodeGen` as a
  primitive for `ClassOf(ClassRef("V"))`, which Scala.js recognizes as
  `java.lang.Void`
- Enable the javalib/lang/ClassTest for Scala.js, which contains a test
  that uses `BoxedUnit.TYPE`
sjrd referenced this issue Oct 22, 2019
@sjrd
Merge pull request #7439 from Lacaranian/add-readers-test
3166433 
Partial fix for lampepfl#7113: Fix Scala.js codegen for Explicit Returns
Lacaranian referenced this issue in Lacaranian/dotty Oct 23, 2019
@Lacaranian
Partial fix for lampepfl#7113: Fix Scala.js codegen for BoxedUnit.TYPE
5980f3e 
- `scala.runtime.BoxedUnit.TYPE` is now intercepted by `JSCodeGen` as a
  primitive for `ClassOf(ClassRef("V"))`, which Scala.js recognizes as
  `java.lang.Void`
- Enable the javalib/lang/ClassTest for Scala.js, which contains a test
  that uses `BoxedUnit.TYPE`
sjrd referenced this issue Oct 23, 2019
@sjrd
Merge pull request #7415 from Lacaranian/add-sjs-class-test
5e503e2 
Partial fix for lampepfl#7113: Fix Scala.js codegen for BoxedUnit.TYPE
@anatoliykmetyuk anatoliykmetyuk mentioned this issue Oct 23, 2019
Merged
Lacaranian referenced this issue in Lacaranian/dotty Oct 26, 2019
@Lacaranian
Partial fix for lampepfl#7113: Fix Scala.js codegen for Null/Nothing …
cd0a0c6 
…types

- Fix the encoding of the `NullClass` and `NothingClass` in `JSEncoding` to
  correctly map to the corresponding Scala.js IR Symbols
- Enable the `javalib/net/URITest` for Scala.js, which uses default
  arguments with `null` values, which in turn are used as the return
  type of the default getters.
Lacaranian referenced this issue in Lacaranian/dotty Oct 28, 2019
@Lacaranian
Partial fix for lampepfl#7113: Fix Scala.js codegen for Null/Nothing …
cdfd672 
…types

- Fix the encoding of the `NullClass` and `NothingClass` in `JSEncoding` to
  correctly map to the corresponding Scala.js IR Symbols
- Enable the `javalib/net/URITest` for Scala.js, which uses default
  arguments with `null` values, which in turn are used as the return
  type of the default getters.
Lacaranian referenced this issue in Lacaranian/dotty Oct 28, 2019
@Lacaranian
Partial fix for lampepfl#7113: Add Scala.js handling of @test annotat…
d49b1a7 
…ions with arguments

To be able to use the `expected` and `timeout` annotation arguments in
JUnit @test annotations, add handling for these arguments by supplying
them as arguments to the resolved constructor for the JUnit test class.

Enable the JUnitAnnotationsParamTest, which depends on this
functionality.
Lacaranian referenced this issue in Lacaranian/dotty Oct 28, 2019
@Lacaranian
Partial fix for lampepfl#7113: Add Scala.js handling of @test annotat…
c5a9764 
…ions with arguments

To be able to use the `expected` and `timeout` annotation arguments in
JUnit @test annotations, add handling for these arguments by supplying
them as arguments to the resolved constructor for the JUnit test class.

Enable the JUnitAnnotationsParamTest, which depends on this
functionality.
Lacaranian referenced this issue in Lacaranian/dotty Oct 28, 2019
@Lacaranian
Partial fix for lampepfl#7113: Add Scala.js handling of @test annotat…
54e49a2 
…ions with arguments

To be able to use the `expected` and `timeout` annotation arguments in
JUnit @test annotations, add handling for these arguments by supplying
them as arguments to the resolved constructor for the JUnit test class.

Enable the JUnitAnnotationsParamTest, which depends on this
functionality.
Lacaranian referenced this issue in Lacaranian/dotty Oct 28, 2019
@Lacaranian
Add Scala.js handling of @test annotations with arguments
ea755e2 
Partial fix for lampepfl#7113

To be able to use the `expected` and `timeout` annotation arguments in
JUnit @test annotations, add handling for these arguments by supplying
them as arguments to the resolved constructor for the JUnit test class.

Enable the JUnitAnnotationsParamTest, which depends on this
functionality.
Lacaranian referenced this issue in Lacaranian/dotty Oct 29, 2019
@Lacaranian
Add Scala.js handling of @test annotations with arguments
78e9a02 
Partial fix for lampepfl#7113

To be able to use the `expected` and `timeout` annotation arguments in
JUnit @test annotations, add handling for these arguments by supplying
them as arguments to the resolved constructor for the JUnit test class.

Enable the JUnitAnnotationsParamTest, which depends on this
functionality.
Lacaranian referenced this issue in Lacaranian/dotty Nov 13, 2019
@Lacaranian
Partial fix for lampepfl#7113: Fix Scala.js codegen for Null/Nothing …
faec468 
…types

- Fix the encoding of the `NullClass` and `NothingClass` in `JSEncoding` to
  correctly map to the corresponding Scala.js IR Symbols
- Enable the `javalib/net/URITest` for Scala.js, which uses default
  arguments with `null` values, which in turn are used as the return
  type of the default getters.
sjrd referenced this issue Nov 13, 2019
@sjrd
Merge pull request #7378 from Lacaranian/more-sjs-tests
4b75572 
Partial fix for lampepfl#7113: Fix Scala.js codegen for Null/Nothing types
abgruszecki referenced this issue in dotty-staging/dotty Dec 5, 2019
@Lacaranian @abgruszecki
Add Scala.js handling of @test annotations with arguments
80007df 
Partial fix for lampepfl#7113

To be able to use the `expected` and `timeout` annotation arguments in
JUnit @test annotations, add handling for these arguments by supplying
them as arguments to the resolved constructor for the JUnit test class.

Enable the JUnitAnnotationsParamTest, which depends on this
functionality.
@squid314 squid314 mentioned this issue May 9, 2020
Merged
squid314 referenced this issue in squid314/dotty May 9, 2020
@squid314
Enable many javalib/util/* tests other than Sets for Scala.js
c484384 
Partial fix for lampepfl#7113

Just enabling the tests which already passed. It looks like the upstream
tests need updating for the Set pieces.
@shelby3 shelby3 mentioned this issue Aug 21, 2020
Open
@sjrd sjrd modified the milestones: 0.18 Tech Preview, 3.0.0-M1 Sep 22, 2020
@sjrd
Copy link
Member Author

sjrd commented Sep 22, 2020

Thanks to all of you who have contributed to the support of Scala.js in Dotty.

Since I've been allocated time at the Scala Center to finish it, it is now almost done, and so I think this issue can be closed.

@sjrd sjrd closed this as completed Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:scala.js exp:novice help wanted
Projects
None yet
Milestone
3.0.0-M1
Development

No branches or pull requests
5 participants
@sjrd @anatoliykmetyuk @cquiroz @neshkeev @Lacaranian