Add layer_name to kwargs of from_images

[markbader]

Description:

• This PR adds the argument layer_name to the Dataset.from_images method. If from_images generates a Dataset with one layer, it uses the given layer_name as name for this layer. In case multiple layers are created, the given layer name is a shared prefix of all layers.

Issues:

• fixes Add layer_name to Dataset.from_images #1053

Todos:

Make sure to delete unnecessary points or to check all before merging:

• Updated Changelog
• Added / Updated Tests

[normanrz]

Can you comment how the layer names for multiple layers are constructed? I don't think I understand that yet. Would it make sense to strip the current prefix (ie. file name based) in that case?

[markbader]

It depends, we currently use the Callable map_filepath_to_layername to generate the layer names. It can either be used by selecting one of the predefined methods defined in ConversionLayerMapping or by delivering a custom Callable to convert the file paths to layer names.
The default behavior is INSPECT_SINGLE_FILE, which distinguishes two different cases. If the first file that is found is 2D ENFORCE_LAYER_PER_FOLDER is used, otherwise ENFORCE_LAYER_PER_FILE will be applied.
ENFORCE_LAYER_PER_FOLDER uses the folder name, where the image file is stored in.
ENFORCE_LAYER_PER_FILE uses the filename.
I think as there are many options for functions that can convert the file path to a layer name, it would not be easy to strip a part of it, and still get unique layer names. Either we decide, that another behavior should be used when the layer_name is set, e.g., just numbering the layers after the common prefix, or we stay with the full filename or folder name based approach. But I would prefer the filename approach because it makes the layers easier to distinguish.

[normanrz]

Thanks for explaining.