Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BoundingBoxNamedTuple #526

Merged
merged 4 commits into from Dec 22, 2021
Merged

Remove BoundingBoxNamedTuple #526

merged 4 commits into from Dec 22, 2021

Conversation

rschwanhold
Copy link
Contributor

@rschwanhold rschwanhold commented Dec 16, 2021 •
edited

Description:

  • Use the normal BoundingBox instead

Issues:

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog

jstriebel
jstriebel approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Nice! :-) Please add a changelog entry, then this should be fine 👍

@rschwanhold rschwanhold enabled auto-merge (squash) December 16, 2021 16:37
@rschwanhold rschwanhold merged commit 45f6125 into master Dec 22, 2021
@rschwanhold rschwanhold deleted the remove-boundingbox-named-tuple branch December 22, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstriebel jstriebel jstriebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

merge BoundingBoxNamedTuple and BoundingBox
2 participants
@rschwanhold @jstriebel