-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Zarr support #627
Initial Zarr support #627
Conversation
I reworked |
I think the remaining points from your review are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍 I think, more of the tests could be generalized to work on wkw and zarr, but I understand that it can be quite a hassle to convert this and the returns are probably diminishing. So, I don't have a hard opinion on that.
I replied to the corresponding comment.
Is this something you need an opinion on? I don't really have a tendency here 🤷
I'd vote for mags, as it's mainly used in newer code, concise and a bit clearer than the others (e.g., dataset resolution could also mean the physical size of a voxel (which we usually but not always refer to as scale)). I see, that it's not necessarily the most common term in the industry, but there will always be naming differences between different organizations/projects (see output ~ artifacts ~ debris). Being consistent within our own ecosystem is what matters most in my opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 🎉
I added a couple of comments, but overall this looks great! On the open questions:
data_format
orarray_format
consistencyIs this something you need an opinion on? I don't really have a tendency here 🤷
Also no strong opinion, but tending a bit towards array_format
, since array
is more specific than data
. (Also fit's the …Array
class renaming suggestion in the comments below)
resolutions
,magnifications
/mags
,multiscales
I'd vote for mags, as it's mainly used in newer code, concise and a bit clearer than the others (e.g., dataset resolution could also mean the physical size of a voxel (which we usually but not always refer to as scale)). I see, that it's not necessarily the most common term in the industry, but there will always be naming differences between different organizations/projects (see output ~ artifacts ~ debris). Being consistent within our own ecosystem is what matters most in my opinion.
Agreeing with @philippotto, but also no strong opinion here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this is good to go 🎉, just the respective Changelog entries are still needed. Leaving the final go to @philippotto 🏁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent 💯 Good to go from my side, too.
Description:
StorageArray
abstraction for WKW and Zarrblock_len
tochunk_size
andfile_len
tochunks_per_shard
, but with backwards-compatible supportpathlib
in more locations instead of string paths. This can be seen as a preparation for usingupath
later on.wkwResolutions
tomags
indatasource-properties.json
for Zarr datasets. cc @fm3Issues:
Todos:
Make sure to delete unnecessary points or to check all before merging: