Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webknossos_context: Guard against trailing slashes in URL #733

Merged
merged 4 commits into from May 18, 2022

Conversation

jstriebel
Copy link
Contributor

@jstriebel jstriebel commented May 18, 2022

Description:

URLs for the webknossos-context (e.g. in the WK_URL env var or via webknossos_context(url=…)) may now contain / in the end and are sanitized. Before, requests would fail if the URL contained a final /.

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog

@jstriebel jstriebel self-assigned this May 18, 2022
@jstriebel jstriebel requested a review from fm3 May 18, 2022 08:27
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jstriebel jstriebel enabled auto-merge (squash) May 18, 2022 08:31
@jstriebel jstriebel merged commit 2392c2a into master May 18, 2022
@jstriebel jstriebel deleted the sanitize-wk-context-url branch May 18, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants