Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_layer_from_images: allow single image folders, retry with bioformats #829

Merged
merged 5 commits into from Dec 2, 2022
Merged

add_layer_from_images: allow single image folders, retry with bioformats #829

merged 5 commits into from Dec 2, 2022

Conversation

jstriebel
Copy link
Contributor

@jstriebel jstriebel commented Nov 30, 2022 •
edited

Description:

Improvments for ds.add_layer_from_images:

Todos:

@jstriebel jstriebel self-assigned this Nov 30, 2022
philippotto
philippotto reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! What do you think about splitting up the _open_images method to make it a bit more readable?

webknossos/webknossos/dataset/_utils/pims_images.py Outdated Show resolved Hide resolved
webknossos/webknossos/dataset/_utils/pims_images.py Outdated Show resolved Hide resolved
webknossos/tests/dataset/test_add_layer_from_images.py Show resolved Hide resolved
@jstriebel
Copy link
Contributor Author

What do you think about splitting up the _open_images method to make it a bit more readable?

Good idea, did that and numbered the errors correctly 👍

philippotto
philippotto approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) 💯

@jstriebel jstriebel merged commit c7d54dc into master Dec 2, 2022
@jstriebel jstriebel deleted the add-layer-from-images-improvements branch December 2, 2022 12:17
@hotzenklotz hotzenklotz mentioned this pull request Dec 5, 2022
Closed
@jstriebel jstriebel mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@jstriebel jstriebel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jstriebel @philippotto