Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some segment actions are not properly disabled for non-editable segmentation layers #7207

Closed
1 task
philippotto opened this issue Jul 17, 2023 · 2 comments · Fixed by #7333
Closed
1 task
Assignees

Comments

@philippotto
Copy link
Member

philippotto commented Jul 17, 2023

Context

Annotation for a dataset with a segmentation layer, but where the segmentation layer is not editable.
https://scm.slack.com/archives/C5AKLAV0B/p1689585308901369?thread_ts=1688991494.182429&cid=C5AKLAV0B

Expected Behavior

  • "create new group" should be disabled
  • user should not be able to rename segments

Current Behavior

  • create new group can be clicked but nothing happens
  • segments can be renamed (on reload, this change will be lost)

Steps to Reproduce the bug

  • Cannot reproduce the bug anymore / needs deeper investigation.
  1. create annotation for a dataset that has a segmentation layer but don't create an editable segmentation layer (e.g., only skeleton annotation layer or create a new/empty segmentation layer)
  2. make sure the non-empty segmentation layer is visible
  3. click on some segments to fill the segment list
  4. use context menu on the root group and try to rename segments
@dieknolle3333
Copy link
Contributor

dieknolle3333 commented Sep 15, 2023

In this list of single segment actions:
Image
and this list of segment group actions:
Image
I am assuming that the only actions that should be possible for visible but uneditable segmentation layers are Remove segment from list and all the mesh actions.
Do you agree or did I misunderstand something?

Edit: Compute Meshes (ad hoc) is currently not working in this case, an error toast appears and the console logs a 400 status code. In other cases, such as an editable segmentation layer, this is working. I don't know whether this means it shouldn't be possible to compute the meshes (same for all the other mesh actions)

@dieknolle3333
Copy link
Contributor

see more details here: https://scm.slack.com/archives/C5AKLAV0B/p1694797660535889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants