disabled some actions when segmentation layer is visible but not edit… #7333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dieknolle3333
commented
Sep 26, 2023
| @@ -1221,7 +1222,7 @@ class SegmentsView extends React.Component<Props, State> { | |||
| this.handleChangeMeshVisibilityInGroup( | |||
| this.props.visibleSegmentationLayer.name, | |||
| groupId, | |||
| !this.areSelectedSegmentsMeshesVisible(), | |||
| !areGroupOrSelectedSegmentMeshesVisible, | |||
There was a problem hiding this comment.
not related to the bug, but saw that this lead to wrong behaviour
hotzenklotz
approved these changes
Sep 28, 2023
|
Tested and works like a charm. One little thing: I can still move segments into groups even when I am not supposed to. This was not directly part of the issue but perhaps it easy to tackle as well. Drag and drop moving a segment into a group should probably be prevented. If this is easy, please fix. Otherwise we merge as is. |
|
if it was just about drag and drop, the fix was easy. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…able
Steps to test:
TODOs:
Issues:
(Please delete unneeded items, merge only when none are left open)