Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional axis limits should be semi-open interval #7515

Closed
fm3 opened this issue Jan 2, 2024 · 1 comment · Fixed by #7547
Closed

Additional axis limits should be semi-open interval #7515

fm3 opened this issue Jan 2, 2024 · 1 comment · Fixed by #7547

Comments

@fm3
Copy link
Member

fm3 commented Jan 2, 2024

Looks like there is some confusion about where the limits of additional axes are inclusive or not (in ngff, in datasource-properties.json, in wk frontend, in wk libs).

We should have a close look to ensure we aren’t running into off-by-one errors anywhere.

Compare https://scm.slack.com/archives/C5AKLAV0B/p1703164015131529?thread_ts=1702999640.527409&cid=C5AKLAV0B for context

@fm3 fm3 changed the title Double check additional axis limits (inclusive interval?) Additional axis limits should be semi-open interval Jan 3, 2024
@fm3
Copy link
Member Author

fm3 commented Jan 3, 2024

I tested around and it looks like the axis limits are currently stored as a closed interval (endpoints included). Should be stored as a half-open interval (minimum included, maximum not included). The explore code, data reading code, and the frontend need to be adjusted, and existing datasets fixed (edit datasource-properties.jsons)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants