Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat ND bounds as inclusive in bucket handling #7535

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Treat ND bounds as inclusive in bucket handling #7535

merged 2 commits into from
Jan 9, 2024

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jan 9, 2024 •
edited
Loading

In the long run, we want to change this to a half-open interval, but for now it should be inclusive.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • load the last t-section in a 4D dataset

Issues:

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Jan 9, 2024
@philippotto philippotto requested a review from fm3 January 9, 2024 16:30
@philippotto philippotto enabled auto-merge (squash) January 9, 2024 16:34
@philippotto philippotto merged commit 33abf96 into master Jan 9, 2024
2 checks passed
@philippotto philippotto deleted the fix-inclusive-bound-nd branch January 9, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philippotto @fm3