Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dataStoreToken rom config and use sth random instead #2196

Merged
merged 8 commits into from Jan 11, 2018

Conversation

jfrohnhofen
Copy link
Contributor

@jfrohnhofen jfrohnhofen commented Dec 1, 2017

Steps to test:

  • open wK do sth that needs the wk-token (e.g. download a volume tracing or create a tracing)
  • be happy that it still works

  • Ready for review

@jstriebel
Copy link
Contributor

PR to remove the config parameter for our deployment:
https://github.com/scalableminds/kube/pull/71

@jfrohnhofen
Copy link
Contributor Author

WARNING: do not merge, until fossilDB is used in production

@jfrohnhofen
Copy link
Contributor Author

@jstriebel do we use fossil in prod everywhere?

@fm3
Copy link
Member

fm3 commented Dec 23, 2017

@jfrohnhofen I believe @jstriebel said that the dev server will switch to fossildb only after it is part of the cluster… or something like that, meaning that this issue is blocked for a little longer

@jfrohnhofen
Copy link
Contributor Author

The main reason this was blocked by FossilDB is, that calling the backup routes is no longer possible, since the token is unknown. This should not matter on dev, since we don't backup rocksdb there, I think.
but does that mean (since fossil is already in master), that we can't deploy the current master on the dev server?

@fm3
Copy link
Member

fm3 commented Dec 23, 2017

Ok I can’t estimate those problems, if jstriebel thinks its okay with the current setup, we can merge all of the fossildb stuff and this.

FossilDB is not actually used in the master branch yet. While the startup scripts there do start a fossildb process, webknossos still uses the libs version 11.3.9 which handles rocksdb directly, as before. So for now, this fossildb process is idle.

@jstriebel
Copy link
Contributor

Current status:
Only the external datastores for mhlab run with FossilDB. Currently we can't deploy dev instances or demo with fossildb. Let's wait until norman or I added this to our helm setup and we all use the new dev environment.

@jstriebel
Copy link
Contributor

@jfrohnhofen , @fm3
As fossildb is almost merged (#2235), could you resolve the conflicts in the imports? I'm not sure which ones to take here.

@jstriebel jstriebel merged commit ad184b6 into master Jan 11, 2018
@jstriebel jstriebel deleted the no-datastore-token branch January 11, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants