make bool2Fox always explicit #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschwanhold
reviewed
Aug 2, 2018
| @@ -408,8 +408,8 @@ class Authentication @Inject()( | |||
|
|
|||
| private def creatingOrganizationsIsAllowed(requestingUser: Option[User]) = { | |||
| val noOrganizationPresent = InitialDataService.assertNoOrganizationsPresent | |||
| val configurationFlagSet = Play.configuration.getBoolean("application.allowOrganzationCreation").getOrElse(false) ?~> "allowOrganzationCreation.notEnabled" | |||
| val userIsSuperUser = requestingUser.exists(_.isSuperUser).toFox | |||
There was a problem hiding this comment.
Is it correct that .toFox and bool2Fox have the same behavior? The only difference is that Boolean does not have a method called .toFox thats why it is implicitly converted to a Fox and then returns itself, while bool2Fox converts it explicitly?
There was a problem hiding this comment.
.toFox is actually a method of Fox. This way, if called on any type that has an implicit conversion to Fox, that conversion will be triggered. This will now no longer work for booleans (as is intended).
rschwanhold
reviewed
Aug 2, 2018
| @@ -42,6 +38,11 @@ trait FoxImplicits { | |||
|
|
|||
| implicit def fox2FutureBox[T](f: Fox[T])(implicit ec: ExecutionContext): Future[Box[T]] = | |||
| f.futureBox | |||
|
|
|||
| // This one is no longer implicit since that has lead to confusion. Should always be used explicitly. | |||
There was a problem hiding this comment.
Is it wanted that it still belongs to FoxImplicits?
There was a problem hiding this comment.
Yeah, that way it is available to all the classes inheriting from that Trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated changelog[ ] Updated migration guide if applicable