Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make active tree node round instead of shifting the hue value #3628

Merged
merged 4 commits into from
Feb 4, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jan 15, 2019

URL of deployed dev instance (used for testing):

Steps to test:

  • open a skeleton tracing and change the active node (e.g., create new nodes)
  • the active node should be round and should have the same color as the other nodes of the same tree

Issues:


@philippotto philippotto self-assigned this Jan 15, 2019
@philippotto philippotto changed the title [Blocked] Make active tree node round instead of shifting the hue value Make active tree node round instead of shifting the hue value Jan 31, 2019
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although the active node is pretty hard to distinguish now imo, but I don't have a better idea :)

@philippotto philippotto merged commit f0fa08e into master Feb 4, 2019
@philippotto philippotto mentioned this pull request Feb 11, 2019
2 tasks
@normanrz normanrz deleted the round-active-node branch February 20, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve highlighting of active node
2 participants