Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (minimal) UI for auto brush and allow it for white-listed datasets #4053

Merged
merged 8 commits into from May 6, 2019

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented May 2, 2019

This PR adds

  • a configurable white-list (via feature flags)
  • a minimal UI (a checkbox) for the auto-brush when a tracing is opened for a whitelisted dataset
  • that the auto-brush mode can be disabled by hitting the escape key

The checkbox itself rather serves the purpose of telling the user about the feature (since it would be not easy to find, otherwise). Maybe the checkbox should be activated by default for whitelisted datasets? And an information icon next to the checkbox could give more insights?

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open a tracing for the dsA dataset (whitelisted by default in the application.conf)
  • the tracing settings should show a checkbox for the autobrush
  • when enabling that checkbox a notification should open which tells the user about the ctrl+click usage
  • after using ctrl+click, the auto-brush mode should be cancellable by hitting the escape key

Issues:


@philippotto philippotto self-assigned this May 2, 2019
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

I think the model we're currently using wasn't trained on "dsA" though, but SegEM instead. I'm not sure which datasets correspond to SegEM - we should find out to get a good default value.

@philippotto philippotto merged commit a859f80 into master May 6, 2019
@philippotto philippotto deleted the whitelist-auto-brush branch May 20, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable auto-brush for predefined datasets Press ESC to escape auto-brush
2 participants