Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ThreeJS to v105 #4151

Merged
merged 3 commits into from
Jun 27, 2019
Merged

Update ThreeJS to v105 #4151

merged 3 commits into from
Jun 27, 2019

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Jun 25, 2019

Updating ThreeJS from v87 to v105 to keep up to date. Originally I wanted to profit from this change, but it seems we'll have to wait for this PR (scheduled for v106) to get non-blocking shader compilation (as well as this one). Should be easy to update, then :)

URL of deployed dev instance (used for testing):

Steps to test:

  • Open tracing view and test three-js related functionality:
    • screenshot views using (Q)
    • node selection in viewports using Shift+Click
    • 3D-View
    • Isosurfaces using Shift+Click (after enabling them in the settings) in a volume tracing

  • Ready for review

@daniel-wer daniel-wer self-assigned this Jun 25, 2019
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ❤️

Also kudos for finding the unused fallbackZoomStep variable. Maybe we can paste the GLSL code into a linter to find similar occurrences?

When can we expect the new threejs release? At the end of this month?

@daniel-wer
Copy link
Member Author

Maybe we can paste the GLSL code into a linter to find similar occurrences?

I tried to find something for this but wasn't successful :/

When can we expect the new threejs release?

The r106 milestone is scheduled for today, let's see :)

@daniel-wer daniel-wer merged commit 96e28c3 into master Jun 27, 2019
@daniel-wer daniel-wer deleted the update-three-105 branch June 27, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants