Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash in arbitrary *view* mode when invoking skeleton-shortcuts #4881

Merged
merged 3 commits into from
Oct 21, 2020
Merged

Don't crash in arbitrary *view* mode when invoking skeleton-shortcuts #4881

merged 3 commits into from
Oct 21, 2020

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Oct 19, 2020 •
edited by daniel-wer

For example, opening a dataset in view mode, switching to arbitrary mode and then pressing shift+space raised an exception.

URL of deployed dev instance (used for testing):

Steps to test:

  • open a dataset in view mode, switch to arbitrary mode and try to break it somehow

Issues:

@philippotto philippotto self-assigned this Oct 19, 2020
daniel-wer
daniel-wer approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and fix! 👍

@bulldozer-boy bulldozer-boy bot merged commit 0553f8e into master Oct 21, 2020
@bulldozer-boy bulldozer-boy bot deleted the fix-arbitrary-without-skeleton branch October 21, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philippotto @daniel-wer