Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Superusers to Join Organizations Unlisted #5151

Merged
merged 5 commits into from Feb 11, 2021
Merged

Allow Superusers to Join Organizations Unlisted #5151

merged 5 commits into from Feb 11, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 10, 2021 •
edited

For webKnossos maintenance, superUsers can now join organizations without being listed as a user there

NOTE that #5149 should be merged first for consecutive schema numbering

Steps to test:

  • create multi-organization setup (e.g. via isDemoOrganization = true)
  • create a second organization
  • as default user (who is a superuser), switch to the new organization, should not be listed there
  • when joining an organization as a normal user, you should be listed there

Issues:

@fm3 fm3 added the backend label Feb 10, 2021
@fm3 fm3 self-assigned this Feb 10, 2021
@fm3 fm3 changed the title [WIP] allow superusers to join organizations unlisted Allow Superusers to Join Organizations Unlisted Feb 10, 2021
@fm3 fm3 marked this pull request as ready for review February 10, 2021 12:20
@fm3 fm3 requested a review from youri-k February 10, 2021 12:20
youri-k
youri-k approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 added automerge and removed automerge labels Feb 11, 2021
@fm3 fm3 added the automerge label Feb 11, 2021
@bulldozer-boy bulldozer-boy bot merged commit 20389cc into master Feb 11, 2021
@bulldozer-boy bulldozer-boy bot deleted the unlisted-superusers branch February 11, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
automerge backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow superusers to join organization unlisted, for maintenance
2 participants
@fm3 @youri-k