Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds ctrl+scroll for zooming #5224

Merged
merged 4 commits into from Mar 2, 2021
Merged

adds ctrl+scroll for zooming #5224

merged 4 commits into from Mar 2, 2021

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Mar 1, 2021

Adds Ctrl+scroll for zooming in and out of ortho planes. This also enables pinch-to-zoom on mac trackpads.

Notes:

  • Flight mode doesn't have a scroll-based zoom
  • Should we also use ctrl+move for moving (as analogue to alt+move)?

Steps to test:

  • Open a dataset
  • Use ctrl+scroll to zoom in
  • Use pinch-to-zoom on a Mac trackpad

Issues:


@normanrz normanrz self-assigned this Mar 1, 2021
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍 Maybe it's a worth a changelog entry?

@normanrz
Copy link
Member Author

normanrz commented Mar 1, 2021

Maybe it's a worth a changelog entry?

Will do

What do you think about Ctrl+Move?

@philippotto
Copy link
Member

What do you think about Ctrl+Move?

I don't have a strong opinion about this, but I'm rather leaning against it. In the past, I noticed that it's easy to move accidentally while zooming via alt+scroll. If we separate the modifiers (alt for moving and ctrl for zooming), we could mitigate this. Also, I'm not super convinced by the alt+mouse-move shortcut. Personally, I'd find something like space+drag more intuitive. Changing from alt to ctrl doesn't really improve it imo. Changing it later once again might be too much churn.

@normanrz normanrz enabled auto-merge (squash) March 2, 2021 10:21
@normanrz normanrz merged commit 9e84f2a into master Mar 2, 2021
@philippotto philippotto deleted the ctrl-scroll branch June 14, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom with track pad
2 participants