Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken context menu in dataset-view-mode when no segmentation layer is visible #6259

Merged
merged 3 commits into from Jun 7, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jun 7, 2022

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • I opened l4_sample, hid the segmentation layer and used the context menu. Before the changes, the page crashed. Now, a context menu with one entry (the clicked position) is shown

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Jun 7, 2022
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing! 👍

@philippotto philippotto enabled auto-merge (squash) June 7, 2022 12:41
@philippotto philippotto merged commit 8993e3c into master Jun 7, 2022
@philippotto philippotto deleted the fix-broken-context-menu branch June 7, 2022 13:08
philippotto added a commit that referenced this pull request Jun 16, 2022
…er is visible (#6259)

* fix broken context menu in dataset-view-mode when no segmentation layer is visible

* update changelog
philippotto added a commit that referenced this pull request Jun 16, 2022
* Fix broken context menu in dataset-view-mode when no segmentation layer is visible (#6259)

* fix broken context menu in dataset-view-mode when no segmentation layer is visible

* update changelog

* Fix benign error toast for public annotations and other improvements (#6271)

* make modals lazy; don't show error toast when fetching token or teams failed; fix padding of share button

* update changelog

* rename makeModalLazy to makeComponentLazy; improve its typings and also use it for the ShareModalView, UserScriptsModal and MergeModalView

* improve typing

* don't try to fetch teams or token in sharing modal when not logged in

* don't show error toast when dataset sharing token could not be acquired (#6279)

Co-authored-by: Daniel <daniel.werner@scalableminds.com>

* update changelog for 22.06.1

Co-authored-by: Daniel <daniel.werner@scalableminds.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wk crashes on right-click when no segmentation is shown
2 participants