Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove remote datastore feature #6392

Merged
merged 6 commits into from Aug 22, 2022
Merged

remove remote datastore feature #6392

merged 6 commits into from Aug 22, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Aug 10, 2022

We haven’t been using this feature introduced in ##3080 for a while.

Steps to test:

  • Normal dataset handling and upload should work as before

Issues:


@fm3 fm3 self-assigned this Aug 10, 2022
@fm3 fm3 changed the title [WIP] remove remote datastore feature remove remote datastore feature Aug 18, 2022
@fm3 fm3 marked this pull request as ready for review August 18, 2022 18:25
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, frontend looks good 👍 backend, too, but it's probably a good idea to let @jstriebel have a look 😃

Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too :-)

@fm3 fm3 merged commit 3ec3e63 into master Aug 22, 2022
@fm3 fm3 deleted the remove-foreign-datastores branch August 22, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove addForeignDataSet feature
3 participants