Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undo/redo for volume interpolation/extrusion #6403

Merged
merged 3 commits into from Aug 16, 2022
Merged

Fix undo/redo for volume interpolation/extrusion #6403

merged 3 commits into from Aug 16, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Aug 15, 2022 •
edited

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • use volume interpolation and extrusion in combination with undo (on master, undo didn't restore the old state correctly)

Issues:

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Aug 15, 2022
daniel-wer
daniel-wer approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, works great 👍

@philippotto philippotto enabled auto-merge (squash) August 16, 2022 07:24
@philippotto philippotto merged commit d556f1d into master Aug 16, 2022
@philippotto philippotto deleted the fix-undo-interpolation branch August 16, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undo is buggy with volume interpolation/extrusion
2 participants
@philippotto @daniel-wer