Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark owner in user list #6832

Merged
merged 5 commits into from
Feb 9, 2023
Merged

Mark owner in user list #6832

merged 5 commits into from
Feb 9, 2023

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Feb 8, 2023

PR adds a simple change to the user list. "Organization Owner" is now a an additional tag.

image

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Switch to user list
  • Check layouting
  • Edit the roles / teams of a test user

Issues:


(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Feb 8, 2023
@@ -474,7 +474,7 @@ class UserListView extends React.PureComponent<Props, State> {
title="Email"
dataIndex="email"
key="email"
width={350}
width={320}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user list is slightly too wide on a 15" screen and causes scrollbars to appear. Slightly making the default width of the email column smaller fits the table inside the available screen space

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@hotzenklotz hotzenklotz enabled auto-merge (squash) February 9, 2023 10:42
@hotzenklotz hotzenklotz merged commit e003e20 into master Feb 9, 2023
@hotzenklotz hotzenklotz deleted the owner_tag branch February 9, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants