Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that segments are added to segment list when using quick select... #6867

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Ensure that segments are added to segment list when using quick select... #6867

merged 3 commits into from
Feb 22, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Feb 22, 2023 •
edited

… or flood fill to create new segments

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • use quick select and floodfill to create new segments --> should be added to segment list
  • floodfill can be tested best by using it to relabel an existing segment (and 2D mode)

Issues:

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Feb 22, 2023
hotzenklotz
hotzenklotz approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works like a charm.

@philippotto philippotto enabled auto-merge (squash) February 22, 2023 12:08
@philippotto philippotto merged commit 980b526 into master Feb 22, 2023
@philippotto philippotto deleted the add-segments-for-quick-select-and-floodfill branch February 22, 2023 12:09
hotzenklotz added a commit that referenced this pull request Feb 22, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into nav…
5db33fb 
…bar-menu

* 'master' of github.com:scalableminds/webknossos:
  Add functions to get and set segment colors to the frontend API (#6853)
  Ensure that segments are added to segment list when using quick select... (#6867)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotzenklotz hotzenklotz hotzenklotz approved these changes

Assignees

@philippotto philippotto

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quick-Selecting voxels does not add them to segments list
2 participants
@philippotto @hotzenklotz