Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rendering negative floats #6895

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Support rendering negative floats #6895

merged 3 commits into from
Mar 21, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Mar 2, 2023 •
edited

URL of deployed dev instance (used for testing):

Steps to test:

Todo:

Issues:

(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto changed the base branch from master to multi-modality March 2, 2023 17:39
@philippotto philippotto self-assigned this Mar 3, 2023
Base automatically changed from multi-modality to master March 20, 2023 12:37
@philippotto philippotto marked this pull request as ready for review March 20, 2023 14:05
daniel-wer
daniel-wer approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works well for me 👍

@philippotto philippotto enabled auto-merge (squash) March 21, 2023 10:55
@philippotto philippotto merged commit 7d41f92 into master Mar 21, 2023
@philippotto philippotto deleted the negative-floats branch March 21, 2023 11:14
hotzenklotz added a commit that referenced this pull request Mar 21, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into dro…
f9990b1 
…pdown-menu

* 'master' of github.com:scalableminds/webknossos:
  Update screenshots (#6934)
  Support rendering negative floats (#6895)
  Fix loading of webworkers in dev mode (#6933)
  Restore cache buster for webworkers (#6932)
  Introduce data vault as storage backend abstraction (#6899)
hotzenklotz added a commit that referenced this pull request Mar 22, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into ema…
0f4fc77 
…il-notification

* 'master' of github.com:scalableminds/webknossos:
  Update screenshots (#6934)
  Support rendering negative floats (#6895)
  Fix loading of webworkers in dev mode (#6933)
  Restore cache buster for webworkers (#6932)
  Introduce data vault as storage backend abstraction (#6899)
  Fix download button for annotations when tiff export is disabled (#6931)
hotzenklotz added a commit that referenced this pull request Mar 22, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into dra…
fc2477a 
…wings

* 'master' of github.com:scalableminds/webknossos:
  Update screenshots (#6934)
  Support rendering negative floats (#6895)
  Fix loading of webworkers in dev mode (#6933)
  Restore cache buster for webworkers (#6932)
  Introduce data vault as storage backend abstraction (#6899)
  Fix download button for annotations when tiff export is disabled (#6931)
  Update PULL_REQUEST_TEMPLATE.md
  Prepare multi modality support (#6748)
  Improvements for terms-of-services modal (#6930)
  Fix creating task types with preferred mode (#6928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negative float values are not rendered correctly
2 participants
@philippotto @daniel-wer