Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate meshes by layer and remove old mesh-storage code #6960

Merged
merged 11 commits into from
Apr 12, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Apr 3, 2023

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • create an an annotation with two volume layers (without fallback is the easiest for testing)
  • create a segment 1 in both layers (should be at different positions ideally)
  • name these segments differently
  • save
  • load isosurfaces for both
  • both segments should appear in the 3D viewport (regardless of layer visibility) <-- maybe we should change that in the future, but I think it's independent of this PR

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Apr 3, 2023
@philippotto
Copy link
Member Author

@fm3 What do you think about removing the mesh-storage related code in the back-end in this PR (see ##5633)? When I started rebuilding the code for proper isolation, I ran into the old, (mostly) dead code and removed it. Do you have capacities for this? Or would you like to postpone it?

@fm3
Copy link
Member

fm3 commented Apr 3, 2023

The last post in the issue stated that we might want to reconsider if we really want to remove that feature (?)

Either way, I’d defer removing the backend code in order not to block this PR until I have time. But I will gladly do so in a follow-up PR

@philippotto
Copy link
Member Author

The last post in the issue stated that we might want to reconsider if we really want to remove that feature (?)

Yes, but I'd put the emphasis on "might" 🙈 The last feedback we got on that topic was over a year ago (and in total it was by one user). The feature was already effectively removed, anyway, and I don't really see big reasons to reintroduce it. For the mentioned use case, one could also find other ways (e.g., create a volume annotation to get the desired shape as an isosurface or allow to create a plane with a skeleton).

Either way, I’d defer removing the backend code in order not to block this PR until I have time. But I will gladly do so in a follow-up PR

Ok, cool 👍

@philippotto philippotto changed the title [WIP] Isolate meshes by layer and remove old mesh-storage code Isolate meshes by layer and remove old mesh-storage code Apr 3, 2023
@philippotto philippotto marked this pull request as ready for review April 3, 2023 12:09
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this bug fixing & refactoring 🥇 🦖 .

I only left some small suggestions (renaming & moving a method into another class). As they are not much work / shouldn't be risky changes I already gave you an approve :) I hope that's alrighty.

I did not check, whether you removed every single method that is not needed anymore is removed. I hope that's ok. If you want me to also check this, just ping me :).

frontend/javascripts/oxalis/controller/mesh_controller.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/controller/mesh_controller.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/controller/scene_controller.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/controller/mesh_controller.ts Outdated Show resolved Hide resolved
@philippotto philippotto enabled auto-merge (squash) April 12, 2023 09:47
@philippotto philippotto merged commit 12c54ff into master Apr 12, 2023
1 check passed
@philippotto philippotto deleted the isolate-meshes branch April 12, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meshes of separate volume layers are not isolated properly
3 participants